Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4978)

Unified Diff: chrome/browser/chromeos/login/screens/error_screen.h

Issue 424613003: Add debug code to help understand SEGV in ~ErrorScreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use pointer instead of uint. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/error_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/screens/error_screen.h
diff --git a/chrome/browser/chromeos/login/screens/error_screen.h b/chrome/browser/chromeos/login/screens/error_screen.h
index 97657780c7118b1682d662c26fb3f1badc444df3..a854816afe81ebad799f69b859500f40a42155f0 100644
--- a/chrome/browser/chromeos/login/screens/error_screen.h
+++ b/chrome/browser/chromeos/login/screens/error_screen.h
@@ -103,7 +103,9 @@ class ErrorScreen : public WizardScreen,
void StartGuestSessionAfterOwnershipCheck(
DeviceSettingsService::OwnershipStatus ownership_status);
+ volatile void* canary_1_; // For debugging of https://crbug.com/396557.
ygorshenin1 2014/08/13 08:36:51 As you're just reading pointer's value, not a valu
Thiemo Nagel 2014/08/13 09:38:48 The sizes of pointer and long depend on the data m
ErrorScreenActor* actor_;
+ volatile void* canary_2_;
OobeDisplay::Screen parent_screen_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/error_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698