Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Side by Side Diff: chrome/browser/chromeos/login/screens/error_screen.h

Issue 424613003: Add debug code to help understand SEGV in ~ErrorScreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use pointer instead of uint. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/error_screen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ERROR_SCREEN_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ERROR_SCREEN_H_
6 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ERROR_SCREEN_H_ 6 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ERROR_SCREEN_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 parent_screen_ = parent_screen; 96 parent_screen_ = parent_screen;
97 } 97 }
98 OobeDisplay::Screen parent_screen() const { return parent_screen_; } 98 OobeDisplay::Screen parent_screen() const { return parent_screen_; }
99 99
100 private: 100 private:
101 // Handles the response of an ownership check and starts the guest session if 101 // Handles the response of an ownership check and starts the guest session if
102 // applicable. 102 // applicable.
103 void StartGuestSessionAfterOwnershipCheck( 103 void StartGuestSessionAfterOwnershipCheck(
104 DeviceSettingsService::OwnershipStatus ownership_status); 104 DeviceSettingsService::OwnershipStatus ownership_status);
105 105
106 volatile void* canary_1_; // For debugging of https://crbug.com/396557.
ygorshenin1 2014/08/13 08:36:51 As you're just reading pointer's value, not a valu
Thiemo Nagel 2014/08/13 09:38:48 The sizes of pointer and long depend on the data m
106 ErrorScreenActor* actor_; 107 ErrorScreenActor* actor_;
108 volatile void* canary_2_;
107 109
108 OobeDisplay::Screen parent_screen_; 110 OobeDisplay::Screen parent_screen_;
109 111
110 scoped_ptr<LoginPerformer> guest_login_performer_; 112 scoped_ptr<LoginPerformer> guest_login_performer_;
111 113
112 base::WeakPtrFactory<ErrorScreen> weak_factory_; 114 base::WeakPtrFactory<ErrorScreen> weak_factory_;
113 115
114 DISALLOW_COPY_AND_ASSIGN(ErrorScreen); 116 DISALLOW_COPY_AND_ASSIGN(ErrorScreen);
115 }; 117 };
116 118
117 } // namespace chromeos 119 } // namespace chromeos
118 120
119 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ERROR_SCREEN_H_ 121 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ERROR_SCREEN_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/error_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698