Makes a window that has been resized to maximized bounds, then maximized and then restored shrink

chrome/browser/ui/window_sizer/window_sizer.cc

Index: chrome/browser/ui/window_sizer/window_sizer.cc
diff --git a/chrome/browser/ui/window_sizer/window_sizer.cc b/chrome/browser/ui/window_sizer/window_sizer.cc
index 34b342b05985c9642d5765b902271582633b2974..7cdf769355f41ca2d7a595ee922af8d75095d81d 100644
--- a/chrome/browser/ui/window_sizer/window_sizer.cc
+++ b/chrome/browser/ui/window_sizer/window_sizer.cc
@@ -224,6 +224,13 @@ void WindowSizer::GetBrowserWindowBoundsAndShowState(
   sizer.DetermineWindowBoundsAndShowState(specified_bounds,
                                           window_bounds,
                                           show_state);
+  if (*show_state == ui::SHOW_STATE_DEFAULT) {

[msw, 2014/07/30 05:46:37]

Can you add unit tests for this new behavior, similar to Ash?

[varkha, 2014/07/30 21:03:15]

Done.

+    gfx::Display display = sizer.GetTargetDisplay(*window_bounds);
+    if (*window_bounds == display.work_area()) {
+      *show_state = ui::SHOW_STATE_MAXIMIZED;
+      sizer.GetDefaultWindowBounds(display, window_bounds);

[msw, 2014/07/30 05:46:37]

Why do you need to set |window_bounds| to the default value here, if it's equal
to display.work_area() above? Will the window get restored to it's bounds prior
to dragging when it's brought out of the maximized state? A comment or two would
be helpful here, since the behavior isn't entirely obvious.

[varkha, 2014/07/30 21:03:15]

Yes, the bounds returned here become the restore bounds once the window gets
maximized after this returns. I've added a comment that explains this.

+    }
+  }
 }
 
 ///////////////////////////////////////////////////////////////////////////////