Makes a window that has been resized to maximized bounds, then maximized and then restored shrink

chrome/browser/ui/window_sizer/window_sizer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/window_sizer/window_sizer.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 206 matching lines @@
   scoped_ptr<StateProvider> state_provider(
       new DefaultStateProvider(app_name, browser));
   scoped_ptr<TargetDisplayProvider> target_display_provider(
       new DefaultTargetDisplayProvider);
   const WindowSizer sizer(state_provider.Pass(),
                           target_display_provider.Pass(),
                           browser);
   sizer.DetermineWindowBoundsAndShowState(specified_bounds,
                                           window_bounds,
                                           show_state);
+  if (*show_state == ui::SHOW_STATE_DEFAULT) {

[msw, 2014/07/30 05:46:37]

Can you add unit tests for this new behavior, similar to Ash?

[varkha, 2014/07/30 21:03:15]

Done.

+    gfx::Display display = sizer.GetTargetDisplay(*window_bounds);
+    if (*window_bounds == display.work_area()) {
+      *show_state = ui::SHOW_STATE_MAXIMIZED;
+      sizer.GetDefaultWindowBounds(display, window_bounds);

[msw, 2014/07/30 05:46:37]

Why do you need to set |window_bounds| to the default value here, if it's equal
to display.work_area() above? Will the window get restored to it's bounds prior
to dragging when it's brought out of the maximized state? A comment or two would
be helpful here, since the behavior isn't entirely obvious.

[varkha, 2014/07/30 21:03:15]

Yes, the bounds returned here become the restore bounds once the window gets
maximized after this returns. I've added a comment that explains this.

+    }
+  }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // WindowSizer, private:
 
 void WindowSizer::DetermineWindowBoundsAndShowState(
     const gfx::Rect& specified_bounds,
     gfx::Rect* bounds,
     ui::WindowShowState* show_state) const {
   DCHECK(bounds);
@@ skipping 198 matching lines @@
 
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kStartMaximized))
     return ui::SHOW_STATE_MAXIMIZED;
 
   if (browser_->initial_show_state() != ui::SHOW_STATE_DEFAULT)
     return browser_->initial_show_state();
 
   // Otherwise we use the default which can be overridden later on.
   return ui::SHOW_STATE_DEFAULT;
 }