Issue 424173002: Revert of Add effect caching to distance field text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424173002: Revert of Add effect caching to distance field text. (Closed)

Created:
6 years, 4 months ago by benchen

Modified:
6 years, 4 months ago

Reviewers:
jvanverth1, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Add effect caching to distance field text. (https://codereview.chromium.org/424103002/) Reason for revert: breaking Chrome canary. Original issue's description: > Add effect caching to distance field text. > > This also is a step towards unifying GrDistanceFieldTextureEffect and GrDistanceFieldLCDTextureEffect. > > Committed: https://skia.googlesource.com/skia/+/137bac067306c5446bc4f9797bedc3bbaf302822 TBR=robertphillips@google.com,jvanverth@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/fdd09c20027ab4e8e9b3e238b518c83bd2eda2b0

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -131 lines)			Patch
M	src/gpu/GrDistanceFieldTextContext.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.cpp	View	5 chunks	+37 lines, -66 lines	0 comments	Download
M	src/gpu/effects/GrDistanceFieldTextureEffect.h	View	8 chunks	+14 lines, -30 lines	0 comments	Download
M	src/gpu/effects/GrDistanceFieldTextureEffect.cpp	View	12 chunks	+16 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

benchen

Created Revert of Add effect caching to distance field text.

6 years, 4 months ago (2014-07-29 17:35:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/424173002/1

6 years, 4 months ago (2014-07-29 17:35:38 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-07-29 17:35:50 UTC) #3

Message was sent while issue was closed.

Change committed as fdd09c20027ab4e8e9b3e238b518c83bd2eda2b0