Chromium Code Reviews Chromium Code Reviews
Issue
424093004:
Improve processing of Bluetooth device discovery on Windows. (Closed)
DescriptionImprove processing of Bluetooth device discovery on Windows.
* Merge all events into DevicesPolled event, as this
better reflects how the underlying discovery work in Windows.
* Process the list of devices from DevicesPolled event with
more granularity so we can detect adding, removing and
updating single devices, and raise the appropriate events
to the Chrome App. Add unit tests.
* Don't emit "DevicesPolled" events when the worker thread
encounters issues enumerating devices and services. Instead,
log warnings and ignore the result of the enumeration. This
is required to avoid a Chrome App being notified of
inconsistent events if the worker thread can't successfully
enumerate all devices/services.
* Fix call to BluetoothFindDeviceOpen to use LUP_FLUSHCACHE
when in "discovery" mode, ensuring services are discovered
using a active SDP request.
BUG=396337
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286755
Patch Set 1 #Patch Set 2 : Code cleanup, add unit tests. #Patch Set 3 : Improve error handling + log errors during polling of Bluetooth devices. #Patch Set 4 : Rebasing, code cleanup, git cl format. #
Total comments: 14
Patch Set 5 : Address code review feedback (nits and memory leak). #Messages
Total messages: 7 (0 generated)
|
