Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: device/bluetooth/bluetooth_adapter_win.h

Issue 424093004: Improve processing of Bluetooth device discovery on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review feedback (nits and memory leak). Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_adapter_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_ 5 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_
6 #define DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_ 6 #define DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 const BluetoothUUID& uuid, 64 const BluetoothUUID& uuid,
65 const ServiceOptions& options, 65 const ServiceOptions& options,
66 const CreateServiceCallback& callback, 66 const CreateServiceCallback& callback,
67 const CreateServiceErrorCallback& error_callback) OVERRIDE; 67 const CreateServiceErrorCallback& error_callback) OVERRIDE;
68 68
69 // BluetoothTaskManagerWin::Observer override 69 // BluetoothTaskManagerWin::Observer override
70 virtual void AdapterStateChanged( 70 virtual void AdapterStateChanged(
71 const BluetoothTaskManagerWin::AdapterState& state) OVERRIDE; 71 const BluetoothTaskManagerWin::AdapterState& state) OVERRIDE;
72 virtual void DiscoveryStarted(bool success) OVERRIDE; 72 virtual void DiscoveryStarted(bool success) OVERRIDE;
73 virtual void DiscoveryStopped() OVERRIDE; 73 virtual void DiscoveryStopped() OVERRIDE;
74 virtual void DevicesDiscovered( 74 virtual void DevicesPolled(const ScopedVector<
75 const ScopedVector<BluetoothTaskManagerWin::DeviceState>& devices) 75 BluetoothTaskManagerWin::DeviceState>& devices) OVERRIDE;
76 OVERRIDE;
77
78 virtual void DevicesUpdated(
79 const ScopedVector<BluetoothTaskManagerWin::DeviceState>& devices)
80 OVERRIDE;
81 76
82 const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner() const { 77 const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner() const {
83 return ui_task_runner_; 78 return ui_task_runner_;
84 } 79 }
85 const scoped_refptr<BluetoothSocketThread>& socket_thread() const { 80 const scoped_refptr<BluetoothSocketThread>& socket_thread() const {
86 return socket_thread_; 81 return socket_thread_;
87 } 82 }
88 83
89 protected: 84 protected:
90 // BluetoothAdapter: 85 // BluetoothAdapter:
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 // NOTE: This should remain the last member so it'll be destroyed and 140 // NOTE: This should remain the last member so it'll be destroyed and
146 // invalidate its weak pointers before any other members are destroyed. 141 // invalidate its weak pointers before any other members are destroyed.
147 base::WeakPtrFactory<BluetoothAdapterWin> weak_ptr_factory_; 142 base::WeakPtrFactory<BluetoothAdapterWin> weak_ptr_factory_;
148 143
149 DISALLOW_COPY_AND_ASSIGN(BluetoothAdapterWin); 144 DISALLOW_COPY_AND_ASSIGN(BluetoothAdapterWin);
150 }; 145 };
151 146
152 } // namespace device 147 } // namespace device
153 148
154 #endif // DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_ 149 #endif // DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_WIN_H_
OLDNEW
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_adapter_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698