Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 423953003: Oilpan: Replace Node* pointers with Member<Node>s (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
oilpan-reviews, tkent
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Oilpan: Replace Node* pointers with Member<Node>s - Make SelectorCheckerContext STACK_ALLOCATED. - Make FocusCandidate STACK_ALLOCATED. - Make TreeBoundaryCrossingRuleSetMap a hash map from Member<Node> to Member<CSSStyleSheetRuleSubSet>. This hash map doesn't need to be weak. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179087

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M Source/core/css/SelectorChecker.h View 1 2 chunks +9 lines, -6 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.h View 1 2 chunks +8 lines, -6 lines 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-07-28 20:05:37 UTC) #1
tkent
lgtm
6 years, 4 months ago (2014-07-28 23:19:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/423953003/20001
6 years, 4 months ago (2014-07-28 23:20:10 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-28 23:59:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 01:05:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19339)
6 years, 4 months ago (2014-07-29 01:05:19 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-07-29 01:07:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/423953003/20001
6 years, 4 months ago (2014-07-29 01:08:31 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 01:58:07 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 02:33:05 UTC) #10
Message was sent while issue was closed.
Change committed as 179087

Powered by Google App Engine
This is Rietveld 408576698