Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: Source/core/page/SpatialNavigation.h

Issue 423953003: Oilpan: Replace Node* pointers with Member<Node>s (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/TreeBoundaryCrossingRules.h ('k') | Source/core/page/SpatialNavigation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/SpatialNavigation.h
diff --git a/Source/core/page/SpatialNavigation.h b/Source/core/page/SpatialNavigation.h
index 2b98a2e7c7f4f13e53fbfa73c221c9856ec64ee9..482b6f6e4c1fd2e539606a05c48b8c1217411f3e 100644
--- a/Source/core/page/SpatialNavigation.h
+++ b/Source/core/page/SpatialNavigation.h
@@ -98,10 +98,12 @@ enum RectsAlignment {
};
struct FocusCandidate {
+ STACK_ALLOCATED();
+public:
FocusCandidate()
- : visibleNode(0)
- , focusableNode(0)
- , enclosingScrollableBox(0)
+ : visibleNode(nullptr)
+ , focusableNode(nullptr)
+ , enclosingScrollableBox(nullptr)
, distance(maxDistance())
, alignment(None)
, isOffscreen(true)
@@ -119,9 +121,9 @@ struct FocusCandidate {
// We handle differently visibleNode and FocusableNode to properly handle the areas of imagemaps,
// where visibleNode would represent the image element and focusableNode would represent the area element.
// In all other cases, visibleNode and focusableNode are one and the same.
- Node* visibleNode;
- Node* focusableNode;
- Node* enclosingScrollableBox;
+ RawPtrWillBeMember<Node> visibleNode;
+ RawPtrWillBeMember<Node> focusableNode;
+ RawPtrWillBeMember<Node> enclosingScrollableBox;
long long distance;
RectsAlignment alignment;
LayoutRect rect;
« no previous file with comments | « Source/core/css/TreeBoundaryCrossingRules.h ('k') | Source/core/page/SpatialNavigation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698