Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 423943005: Revert of Remove relative path to GrColor.h in SkShader.h (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, gw280
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Remove relative path to GrColor.h in SkShader.h (https://codereview.chromium.org/422023005/) Reason for revert: As Ben suspected, this breaks the chrome build. Original issue's description: > Remove relative path to GrColor.h in SkShader.h > > Committed: https://skia.googlesource.com/skia/+/939f430f660d26e46116a38d2a8436afbd55dfb9 TBR=bungeman@google.com,george@mozilla.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/4beef91ec04b2edfbe983e672d50cd8f477eda7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M gyp/core.gyp View 3 chunks +2 lines, -3 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Remove relative path to GrColor.h in SkShader.h
6 years, 4 months ago (2014-07-28 20:41:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/423943005/1
6 years, 4 months ago (2014-07-28 20:42:52 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 20:43:10 UTC) #3
Message was sent while issue was closed.
Change committed as 4beef91ec04b2edfbe983e672d50cd8f477eda7f

Powered by Google App Engine
This is Rietveld 408576698