Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 423943003: Remove gpu support for willUseHWAALines. (Closed)

Created:
6 years, 4 months ago by egdaniel
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove gpu support for willUseHWAALines. By removing willUseHWAALines, we also no long reference the blend opt flag kDisableBlend so it has been removed BUG=skia: Committed: https://skia.googlesource.com/skia/+/e6dfba868c19b00562f8c733b9bf37dd4ec9e68c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove all references to smoothLine #

Total comments: 1

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -128 lines) Patch
M include/gpu/GrTypes.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +4 lines, -8 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 3 chunks +5 lines, -11 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +7 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 1 chunk +1 line, -9 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 chunks +33 lines, -74 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
egdaniel
6 years, 4 months ago (2014-07-28 19:36:11 UTC) #1
bsalomon
https://codereview.chromium.org/423943003/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/423943003/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode2169 src/gpu/gl/GrGpuGL.cpp:2169: GL_CALL(Disable(GR_GL_LINE_SMOOTH)); We already disable this in onResetContext. Let's get ...
6 years, 4 months ago (2014-07-28 19:46:05 UTC) #2
egdaniel
ptal
6 years, 4 months ago (2014-07-29 13:54:26 UTC) #3
bsalomon
lgtm w/ a couple nits. kAA_GrGLBackendState isn't used anywhere we know of currently. Might as ...
6 years, 4 months ago (2014-07-29 14:03:54 UTC) #4
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 4 months ago (2014-07-29 14:31:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/423943003/40001
6 years, 4 months ago (2014-07-29 14:31:47 UTC) #6
commit-bot: I haz the power
Change committed as e6dfba868c19b00562f8c733b9bf37dd4ec9e68c
6 years, 4 months ago (2014-07-29 14:51:07 UTC) #7
egdaniel
6 years, 4 months ago (2014-07-29 15:51:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/430493003/ by egdaniel@google.com.

The reason for reverting is: Breaking windows 7 compare gm's.

Powered by Google App Engine
This is Rietveld 408576698