Issue 423763002: Animations: Fix bug where getAnimationPlayers() crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423763002: Animations: Fix bug where getAnimationPlayers() crashes (Closed)

Created:
6 years, 4 months ago by samli

Modified:
6 years, 4 months ago

Reviewers:
Timothy Loh, alancutter (OOO until 2018)

CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, darktears, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Animations: Fix bug where getAnimationPlayers() crashes ElementAnimation:getAnimationPlayers() crashes when it is called and no animations have been previously created on the element. BUG=396376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179001

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	LayoutTests/web-animations-api/w3c/getAnimationPlayers.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/core/animation/ElementAnimation.h	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Timothy Loh

On 2014/07/28 01:44:49, samli wrote: seems fine, lgtm

6 years, 4 months ago (2014-07-28 01:49:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/423763002/1

6 years, 4 months ago (2014-07-28 02:07:28 UTC) #4

Message was sent while issue was closed.

Change committed as 179001

Expand Messages | Collapse Messages