Source/web/WebMediaPlayerClientImpl.cpp - Issue 423633002: Make HTMLMediaElement.setMediaKeys() asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.cpp

Issue 423633002: Make HTMLMediaElement.setMediaKeys() asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: expand comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp ('K') | « Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl ('k') | public/platform/WebMediaPlayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/WebMediaPlayerClientImpl.cpp

diff --git a/Source/web/WebMediaPlayerClientImpl.cpp b/Source/web/WebMediaPlayerClientImpl.cpp

index 8ae9ba35a8c2767d27701d7cd673129784e9af49..7dc86ace642fdb345678dac24d209ae3c0473631 100644

--- a/Source/web/WebMediaPlayerClientImpl.cpp

+++ b/Source/web/WebMediaPlayerClientImpl.cpp

@@ -207,7 +207,7 @@ void WebMediaPlayerClientImpl::load(WebMediaPlayer::LoadType loadType, const WTF

m_webMediaPlayer->setPoster(poster);

// Tell WebMediaPlayer about any connected CDM (may be null).

- m_webMediaPlayer->setContentDecryptionModule(HTMLMediaElementEncryptedMedia::contentDecryptionModule(mediaElement()));

+ m_webMediaPlayer->setContentDecryptionModuleSync(HTMLMediaElementEncryptedMedia::contentDecryptionModule(mediaElement()));

jamesr 2014/08/15 00:56:43 why does this call have to be synchronous? will th

jrummell 2014/08/15 18:32:06 The current HTML standard for resource fetching is

m_webMediaPlayer->load(loadType, kurl, corsMode);

}