Make HTMLMediaElement.setMediaKeys() asynchronous.

Source/web/WebMediaPlayerClientImpl.cpp

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/WebMediaPlayerClientImpl.h"
 
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/TimeRanges.h"
@@ skipping 189 matching lines @@
 #if ENABLE(WEB_AUDIO)
     // Make sure if we create/re-create the WebMediaPlayer that we update our wrapper.
     m_audioSourceProvider.wrap(m_webMediaPlayer->audioSourceProvider());
 #endif
 
     m_webMediaPlayer->setVolume(mediaElement().effectiveMediaVolume());
 
     m_webMediaPlayer->setPoster(poster);
 
     // Tell WebMediaPlayer about any connected CDM (may be null).
-    m_webMediaPlayer->setContentDecryptionModule(HTMLMediaElementEncryptedMedia::contentDecryptionModule(mediaElement()));
+    m_webMediaPlayer->setContentDecryptionModuleSync(HTMLMediaElementEncryptedMedia::contentDecryptionModule(mediaElement()));

[jamesr, 2014/08/15 00:56:43]

why does this call have to be synchronous? will the load behave differently if
it isn't?

[jrummell, 2014/08/15 18:32:06]

The current HTML standard for resource fetching is synchronous.

In this state (newly created player) setContentDecryptionModuleSync() and
setContentDecryptionModule() do the same thing. Rather than relying on
setContentDecryptionModule() to complete immediately (or even worse, adding a
wait), I added this method to make it clear it needs to be synchronous. The
Chromium side checks that it can be synchronous
(https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...).

     m_webMediaPlayer->load(loadType, kurl, corsMode);
 }
 
 void WebMediaPlayerClientImpl::setPreload(MediaPlayer::Preload preload)
 {
     if (m_webMediaPlayer)
         m_webMediaPlayer->setPreload(static_cast<WebMediaPlayer::Preload>(preload));
 }
 
 #if ENABLE(WEB_AUDIO)
@@ skipping 73 matching lines @@
 }
 
 void WebMediaPlayerClientImpl::AudioClientImpl::trace(Visitor* visitor)
 {
     visitor->trace(m_client);
 }
 
 #endif
 
 } // namespace blink