Fix TypeError when closing overlay

Fix TypeError when closing overlay

Hitting Escape repeatedly to close an overlay can trigger a TypeError
if Escape is pressed again before the overlay is fully hidden.

overlays.js and options_page.js have differing opinions on when an
overlay is visible, so overlays.js will send the Esc event while
the overlay is animating out.

R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285790

[michaelpg, 2014-07-25 22:19:55]

There may be a cleaner way to do this by changing how overlays.js works but it
doesn't seem worth it.

[Evan Stade, 2014-07-25 22:39:13]

lgtm

[michaelpg, 2014-07-25 22:50:45]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2014-07-25 22:51:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelpg@chromium.org/423583003/1

[commit-bot: I haz the power, 2014-07-26 05:03:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/33585)

[commit-bot: I haz the power, 2014-07-26 11:08:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-26 19:40:41]

Change committed as 285790