chrome/browser/resources/options/options_page.js - Issue 423583003: Fix TypeError when closing overlay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/options_page.js

Issue 423583003: Fix TypeError when closing overlay (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/options_page.js

diff --git a/chrome/browser/resources/options/options_page.js b/chrome/browser/resources/options/options_page.js

index 968bb4794a062c89924676d1436879bf1991f33d..51dd79ff05624c0a2fa6906d650040f841972210 100644

--- a/chrome/browser/resources/options/options_page.js

+++ b/chrome/browser/resources/options/options_page.js

@@ -355,6 +355,8 @@ cr.define('options', function() {

// Blur the active element to ensure any changed pref value is saved.

document.activeElement.blur();

var overlay = this.getVisibleOverlay_();

+ if (!overlay)

+ return;

// Let the overlay handle the <Esc> if it wants to.

if (overlay.handleCancel) {

overlay.handleCancel();

« no previous file with comments | « no previous file | no next file » | no next file with comments »