Issue 423483006: Cleanup return values in chrome/common/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423483006: Cleanup return values in chrome/common/extensions (Closed)

Created:
6 years, 5 months ago by lucinka.brozkova

Modified:
6 years, 5 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup return values in chrome/common/extensions This CL turns const by value return values into const by ref. Replacing const value by a const ref when a member variable is returned is safe, because the member variable will live at least as long as the temporary object returned now. It can also be more efficient, because returning a ref can spare copying. BUG=393155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285691

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/common/extensions/manifest_handlers/mime_types_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

lucinka.brozkova

Hi yoz@, Could you please do an OWNERS review? Thank you. Lucie

6 years, 5 months ago (2014-07-25 19:27:03 UTC) #1

lucinka.brozkova

The CQ bit was checked by lucinka.brozkova@gmail.com

6 years, 5 months ago (2014-07-25 19:34:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lucinka.brozkova@gmail.com/423483006/1

6 years, 5 months ago (2014-07-25 19:35:17 UTC) #4

Message was sent while issue was closed.

Change committed as 285691

Expand Messages | Collapse Messages