chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h - Issue 423483006: Cleanup return values in chrome/common/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h

Issue 423483006: Cleanup return values in chrome/common/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h

diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h

index 733b2a604ac342022da41240dcea1f9c1767cb82..45a570f0fea42f07b528422802c06e486ecda8f9 100644

--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h

+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h

@@ -48,7 +48,7 @@ class FileBrowserHandler {

void ClearPatterns();

// Action icon path.

- const std::string icon_path() const { return default_icon_path_; }

+ const std::string& icon_path() const { return default_icon_path_; }

void set_icon_path(const std::string& path) {

default_icon_path_ = path;

}

« no previous file with comments | « no previous file | chrome/common/extensions/manifest_handlers/mime_types_handler.h » ('j') | no next file with comments »