DevTools: move the "Capture *" checkboxes from timeline sidebar to the toolbar.

DevTools: move the "Capture *" checkboxes from timeline sidebar to the toolbar.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179156

[apavlov, 2014-07-25 09:10:10]

Not quite familiar with the code in question, but no flaws detected. I'd suggest
asking vsevik@ about the ShortcutRegistry fix (I'm 99% sure the fix is correct,
but he might have had some other ideas related to his change.)

https://codereview.chromium.org/423433004/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelineFrameOverview.js (right):

https://codereview.chromium.org/423433004/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelineFrameOverview.js:139: const targetFPS
= 20;
They say "const" prevents function optimizations. Let's use "var", perhaps with
the /** @const */ annotation whenever required?

https://codereview.chromium.org/423433004/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/ShortcutRegistry.js (right):

https://codereview.chromium.org/423433004/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/ShortcutRegistry.js:72:
result.push(descriptors[j].key);
Seva, was there anything more to your keys-descriptors change (
https://codereview.chromium.org/377253002 )? I'm not quite familiar with it, so
cannot just say this fix is trivial :)

[yurys, 2014-07-29 08:23:01]

Please attach a screenshot. LGTM.

[pfeldman, 2014-07-29 12:15:39]

http://grab.by/yZ3S

[pfeldman, 2014-07-29 12:15:44]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-29 12:16:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/423433004/1

[commit-bot: I haz the power, 2014-07-29 13:26:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/17517)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19457)

[commit-bot: I haz the power, 2014-07-29 13:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 13:51:34]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[pfeldman, 2014-07-29 14:30:13]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-29 14:30:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/423433004/20001

[commit-bot: I haz the power, 2014-07-29 15:46:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-07-29 16:01:47]

Change committed as 179156