Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 377253002: DevTools: Add support for showing shortcuts based on shortcuts registry and use it for pause/resume… (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Add support for showing shortcuts based on shortcuts registry and use it for pause/resume shortcut. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M Source/devtools/front_end/components/ShortcutsScreen.js View 2 chunks +1 line, -6 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/KeyboardShortcut.js View 2 chunks +15 lines, -10 lines 0 comments Download
M Source/devtools/front_end/ui/ShortcutRegistry.js View 3 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vsevik
PTAL
6 years, 5 months ago (2014-07-09 13:54:53 UTC) #1
apavlov
lgtm
6 years, 5 months ago (2014-07-09 14:18:55 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 5 months ago (2014-07-09 14:19:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/377253002/1
6 years, 5 months ago (2014-07-09 14:19:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-09 15:21:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 16:19:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16079)
6 years, 5 months ago (2014-07-09 16:19:13 UTC) #7
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-10 11:32:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/377253002/1
6 years, 5 months ago (2014-07-10 11:32:42 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 12:10:05 UTC) #10
Message was sent while issue was closed. 
Change committed as 177821

Powered by Google App Engine
This is Rietveld 408576698