Convert SerialIoHandler to use buffer interfaces for I/O API methods.

Convert SerialIoHandler to use buffer interfaces for I/O API methods.

These buffer interfaces will allow SerialIoHandler to support both the
existing SerialConnection implementation and one implemented using Mojo
data pipes.

BUG=389016
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287277

[raymes, 2014-08-01 02:25:43]

https://codereview.chromium.org/423373002/diff/80001/device/serial/buffer.h
File device/serial/buffer.h (right):

https://codereview.chromium.org/423373002/diff/80001/device/serial/buffer.h#n...
device/serial/buffer.h:16: class ReadOnlyBuffer {
Maybe just "ReadBuffer" and "WriteBuffer" (since I think the WritableBuffer is
really "write only" as well?)

[Sam McNally, 2014-08-01 06:30:31]

https://codereview.chromium.org/423373002/diff/80001/device/serial/buffer.h
File device/serial/buffer.h (right):

https://codereview.chromium.org/423373002/diff/80001/device/serial/buffer.h#n...
device/serial/buffer.h:16: class ReadOnlyBuffer {
On 2014/08/01 02:25:43, raymes wrote:
> Maybe just "ReadBuffer" and "WriteBuffer" (since I think the WritableBuffer is
> really "write only" as well?)

Using ReadBuffer and WriteBuffer gets a bit confusing. You end up with Write()
taking a ReadBuffer and Read() taking a WriteBuffer.

[Ken Rockot(use gerrit already), 2014-08-01 16:46:54]

lgtm

I think the buffer type naming will be a little confusing either way, but I
agree that ReadOnly and Writable are less confusing names.

[Sam McNally, 2014-08-04 00:21:38]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-08-04 00:21:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/423373002/80001

[commit-bot: I haz the power, 2014-08-04 02:30:45]

Change committed as 287277