device/serial/serial_connection.cc - Issue 423373002: Convert SerialIoHandler to use buffer interfaces for I/O API methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_connection.cc

Issue 423373002: Convert SerialIoHandler to use buffer interfaces for I/O API methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js-serial

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/serial/serial_connection.cc

diff --git a/device/serial/serial_connection.cc b/device/serial/serial_connection.cc

index 0f6dc855c0dc54b88b66c58c4129e70b5848e603..c59aad205f5e223fd26731d099e99cc79d766df9 100644

--- a/device/serial/serial_connection.cc

+++ b/device/serial/serial_connection.cc

@@ -10,7 +10,6 @@ namespace device {

SerialConnection::SerialConnection(scoped_refptr<SerialIoHandler> io_handler)

: io_handler_(io_handler) {

- // TODO(sammc): Call io_handler_->Initialize() once we support send and recv.

}

SerialConnection::~SerialConnection() {

« device/serial/buffer.h ('K') | « device/serial/serial.gyp ('k') | device/serial/serial_io_handler.h » ('j') | no next file with comments »