Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 423363005: Fix ScopedTestNSSDB for older NSS versions. (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix ScopedTestNSSDB for older NSS versions. Before, if NSS version was < 3.15.1, then the ScopedTempDir was destructed without ScopedAllowIO and lead to a thread restriction violation. Now, the temp dir is not deleted in this case as the NSS DB is left open. BUG=210525 TBR=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M crypto/scoped_test_nss_db.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pneubeck (no reviews)
6 years, 4 months ago (2014-08-03 09:59:09 UTC) #1
pneubeck (no reviews)
We should investigate next week what the correct handling of the temp dir is. For ...
6 years, 4 months ago (2014-08-03 09:59:48 UTC) #2
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-03 10:00:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/423363005/1
6 years, 4 months ago (2014-08-03 10:00:43 UTC) #4
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-03 11:36:06 UTC) #5
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 4 months ago (2014-08-03 11:36:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/423363005/1
6 years, 4 months ago (2014-08-03 11:36:43 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-03 12:47:46 UTC) #8
Message was sent while issue was closed.
Change committed as 287257

Powered by Google App Engine
This is Rietveld 408576698