Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: crypto/scoped_test_nss_db.cc

Issue 423363005: Fix ScopedTestNSSDB for older NSS versions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "crypto/scoped_test_nss_db.h" 5 #include "crypto/scoped_test_nss_db.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/threading/thread_restrictions.h" 8 #include "base/threading/thread_restrictions.h"
9 #include "crypto/nss_util.h" 9 #include "crypto/nss_util.h"
10 #include "crypto/nss_util_internal.h" 10 #include "crypto/nss_util_internal.h"
(...skipping 11 matching lines...) Expand all
22 return; 22 return;
23 23
24 const char kTestDescription[] = "Test DB"; 24 const char kTestDescription[] = "Test DB";
25 slot_ = OpenSoftwareNSSDB(temp_dir_.path(), kTestDescription); 25 slot_ = OpenSoftwareNSSDB(temp_dir_.path(), kTestDescription);
26 } 26 }
27 27
28 ScopedTestNSSDB::~ScopedTestNSSDB() { 28 ScopedTestNSSDB::~ScopedTestNSSDB() {
29 // Don't close when NSS is < 3.15.1, because it would require an additional 29 // Don't close when NSS is < 3.15.1, because it would require an additional
30 // sleep for 1 second after closing the database, due to 30 // sleep for 1 second after closing the database, due to
31 // http://bugzil.la/875601. 31 // http://bugzil.la/875601.
32 if (!NSS_VersionCheck("3.15.1") || !slot_) 32 if (!NSS_VersionCheck("3.15.1")) {
33 LOG(ERROR) << "NSS version is < 3.15.1, test DB will not be closed.";
34 temp_dir_.Take();
33 return; 35 return;
36 }
34 37
35 // NSS is allowed to do IO on the current thread since dispatching 38 // NSS is allowed to do IO on the current thread since dispatching
36 // to a dedicated thread would still have the affect of blocking 39 // to a dedicated thread would still have the affect of blocking
37 // the current thread, due to NSS's internal locking requirements 40 // the current thread, due to NSS's internal locking requirements
38 base::ThreadRestrictions::ScopedAllowIO allow_io; 41 base::ThreadRestrictions::ScopedAllowIO allow_io;
39 42
40 SECStatus status = SECMOD_CloseUserDB(slot_.get()); 43 if (slot_) {
41 if (status != SECSuccess) 44 SECStatus status = SECMOD_CloseUserDB(slot_.get());
42 PLOG(ERROR) << "SECMOD_CloseUserDB failed: " << PORT_GetError(); 45 if (status != SECSuccess)
46 PLOG(ERROR) << "SECMOD_CloseUserDB failed: " << PORT_GetError();
47 }
43 48
44 if (!temp_dir_.Delete()) 49 if (!temp_dir_.Delete())
45 LOG(ERROR) << "Could not delete temporary directory."; 50 LOG(ERROR) << "Could not delete temporary directory.";
46 } 51 }
47 52
48 } // namespace crypto 53 } // namespace crypto
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698