Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 423293002: Update the size expectation of sizeof(CSSValue) (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
oilpan-reviews, tkent, Yuki
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Update the size expectation of sizeof(CSSValue) This is a follow-up CL for r179158. Applied tkent-san's comment in https://codereview.chromium.org/427803003/#msg4. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179189

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/core/css/CSSValue.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-07-29 23:16:24 UTC) #1
tkent
lgtm
6 years, 4 months ago (2014-07-29 23:55:22 UTC) #2
haraken
6 years, 4 months ago (2014-07-29 23:55:47 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-07-29 23:55:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/423293002/20001
6 years, 4 months ago (2014-07-29 23:56:32 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 02:45:04 UTC) #6
Message was sent while issue was closed.
Change committed as 179189

Powered by Google App Engine
This is Rietveld 408576698