Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Side by Side Diff: Source/core/css/CSSValue.cpp

Issue 423293002: Update the size expectation of sizeof(CSSValue) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Andreas Kling (kling@webkit.org) 2 * Copyright (C) 2011 Andreas Kling (kling@webkit.org)
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 #include "core/css/CSSReflectValue.h" 51 #include "core/css/CSSReflectValue.h"
52 #include "core/css/CSSSVGDocumentValue.h" 52 #include "core/css/CSSSVGDocumentValue.h"
53 #include "core/css/CSSShadowValue.h" 53 #include "core/css/CSSShadowValue.h"
54 #include "core/css/CSSTimingFunctionValue.h" 54 #include "core/css/CSSTimingFunctionValue.h"
55 #include "core/css/CSSTransformValue.h" 55 #include "core/css/CSSTransformValue.h"
56 #include "core/css/CSSUnicodeRangeValue.h" 56 #include "core/css/CSSUnicodeRangeValue.h"
57 #include "core/css/CSSValueList.h" 57 #include "core/css/CSSValueList.h"
58 58
59 namespace blink { 59 namespace blink {
60 60
61 struct SameSizeAsCSSValue : public RefCountedWillBeGarbageCollectedFinalized<Sam eSizeAsCSSValue>, public ScriptWrappableBase { 61 struct SameSizeAsCSSValue : public RefCountedWillBeGarbageCollectedFinalized<Sam eSizeAsCSSValue>
62 // FIXME: Figure out why only win builds with oilpan increase sizeof(CSSValue).
63 // Deriving ScriptWrappableBase should not increase sizeof(CSSValue).
64 #if ENABLE(OILPAN) && OS(WIN)
65 , public ScriptWrappableBase
66 #endif
67 {
62 uint32_t bitfields; 68 uint32_t bitfields;
63 }; 69 };
64 70
65 COMPILE_ASSERT(sizeof(CSSValue) <= sizeof(SameSizeAsCSSValue), CSS_value_should_ stay_small); 71 COMPILE_ASSERT(sizeof(CSSValue) <= sizeof(SameSizeAsCSSValue), CSS_value_should_ stay_small);
66 72
67 class TextCloneCSSValue : public CSSValue { 73 class TextCloneCSSValue : public CSSValue {
68 public: 74 public:
69 static PassRefPtrWillBeRawPtr<TextCloneCSSValue> create(ClassType classType, const String& text) 75 static PassRefPtrWillBeRawPtr<TextCloneCSSValue> create(ClassType classType, const String& text)
70 { 76 {
71 return adoptRefWillBeNoop(new TextCloneCSSValue(classType, text)); 77 return adoptRefWillBeNoop(new TextCloneCSSValue(classType, text));
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 return toCSSTransformValue(this)->cloneForCSSOM(); 621 return toCSSTransformValue(this)->cloneForCSSOM();
616 case ImageSetClass: 622 case ImageSetClass:
617 return toCSSImageSetValue(this)->cloneForCSSOM(); 623 return toCSSImageSetValue(this)->cloneForCSSOM();
618 default: 624 default:
619 ASSERT(!isSubtypeExposedToCSSOM()); 625 ASSERT(!isSubtypeExposedToCSSOM());
620 return TextCloneCSSValue::create(classType(), cssText()); 626 return TextCloneCSSValue::create(classType(), cssText());
621 } 627 }
622 } 628 }
623 629
624 } 630 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698