Issue 423263002: gn win: Add system include directories to midl template

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423263002: gn win: Add system include directories to midl template (Closed)

Created:
6 years, 4 months ago by scottmg

Modified:
6 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

gn win: Add system include directories to midl template Otherwise, midl.exe will fail to find standard .idls, e.g.: midl : command line error MIDL1001 : cannot open input file objidl.idl R=brettw@chromium.org BUG=354261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286437

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -15 lines)			Patch
M	build/config/win/BUILD.gn	View		1 chunk	+1 line, -15 lines	0 comments	Download
M	build/config/win/visual_studio_version.gni	View		2 chunks	+24 lines, -0 lines	0 comments	Download
M	build/toolchain/win/midl.gni	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/423263002/20001

6 years, 4 months ago (2014-07-29 22:52:40 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...

6 years, 4 months ago (2014-07-30 01:39:47 UTC) #5

Message was sent while issue was closed.

Change committed as 286437