Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3669)

Unified Diff: build/config/win/BUILD.gn

Issue 423263002: gn win: Add system include directories to midl template (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/win/visual_studio_version.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index 3fed26abe8cca492da354ea6e3aa509254fef867..d94dec389d78bde2e3349d285266f8365dbf46cb 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -20,23 +20,9 @@ config("sdk") {
"WINVER=0x0602",
]
- # The Windows SDK include directories must be first. They both have a sal.h,
- # and the SDK one is newer and the SDK uses some newer features from it not
- # present in the Visual Studio one.
- include_dirs = [
- "$windows_sdk_path\Include\shared",
- "$windows_sdk_path\Include\um",
- "$windows_sdk_path\Include\winrt",
- "$visual_studio_path\VC\include",
- "$visual_studio_path\VC\atlmfc\include",
- ]
+ include_dirs = system_include_dirs
if (is_visual_studio_express) {
- include_dirs += [
- "$wdk_path/inc/atl71",
- "$wdk_path/inc/mfc42",
- ]
-
# https://code.google.com/p/chromium/issues/detail?id=372451#c20
# Warning 4702 ("Unreachable code") should be re-enabled once Express users
# are updated to VS2013 Update 2.
« no previous file with comments | « no previous file | build/config/win/visual_studio_version.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698