Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 423173003: Incorrect Static Position of Absolute Positioned Elements inside Rel-Positioned Containers (Closed)

Created:
6 years, 4 months ago by rhogan
Modified:
6 years, 4 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Incorrect Static Position of Absolute Positioned Elements inside Rel-Positioned Containers Per http://www.w3.org/TR/CSS2/visudet.html#abs-non-replaced-width if an absolute positioned box's 'left' and 'right' values are both auto then it should position itself as though it is a normal flow box in relation to its containing block. Where the positioned box's container is a rel-positioned inline we should disregard any offset created by that inline when positioning the positioned box's layer. This bug was spotted during a discussion at http://lists.w3.org/Archives/Public/www-style/2014Jul/0549.html. The tests are drawn from that discussion and attributed appropriately. BUG=398164 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180488

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -9 lines) Patch
A LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-001.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-001-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-offset-001.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-offset-001-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rhogan
6 years, 4 months ago (2014-08-05 18:33:30 UTC) #1
leviw_travelin_and_unemployed
Took me a bit to reason around this, but lgtm!
6 years, 4 months ago (2014-08-18 19:15:36 UTC) #2
rhogan
The CQ bit was checked by robhogan@gmail.com
6 years, 4 months ago (2014-08-18 19:33:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/423173003/20001
6 years, 4 months ago (2014-08-18 19:34:28 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 19:39:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180488

Powered by Google App Engine
This is Rietveld 408576698