Add method getAllHeaders to HttpUrlRequest.

Add method getAllHeaders to get HttpUrlRequest response headers. It handles multiple headers with the same name.
For compatibility with HttpUrlConnection it includes Http status line as value for NULL key.

BUG=390267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287597

[mef, 2014-08-04 21:11:59]

Hi, please take a look.
Miloslav, it is based on your https://codereview.chromium.org/367763004/, but it
uses JNI generator and response headers.

[mmenke, 2014-08-04 21:39:55]

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ja...
File components/cronet/android/java/src/org/chromium/net/UrlRequest.java
(right):

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:422: }
I believe this is generally considered an anti-pattern.  May be better to just
write it out.

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:423: 
nit:  Remove extra whitespace.

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ur...
File components/cronet/android/url_request_peer.h (right):

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ur...
components/cronet/android/url_request_peer.h:95: net::HttpResponseHeaders*
response_headers() const;
If this isn't inlined, should get called GetResponseHeaders.

[mef, 2014-08-04 21:57:53]

thanks!

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ja...
File components/cronet/android/java/src/org/chromium/net/UrlRequest.java
(right):

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:422: }
On 2014/08/04 21:39:55, mmenke wrote:
> I believe this is generally considered an anti-pattern.  May be better to just
> write it out.
Yeah, I've started without it, but JNI generator was confused by generics. I've
added a comment.

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:423: 
On 2014/08/04 21:39:55, mmenke wrote:
> nit:  Remove extra whitespace.

Done.

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ur...
File components/cronet/android/url_request_peer.h (right):

https://codereview.chromium.org/423163007/diff/1/components/cronet/android/ur...
components/cronet/android/url_request_peer.h:95: net::HttpResponseHeaders*
response_headers() const;
On 2014/08/04 21:39:55, mmenke wrote:
> If this isn't inlined, should get called GetResponseHeaders.

Done.

[mmenke, 2014-08-05 17:34:05]

LGTM

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
File components/cronet/android/java/src/org/chromium/net/UrlRequest.java
(right):

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:282: public
Map<String, List<String>> getAllHeaders() {
Do you mind merging ChromiumUrlRequest and UrlRequest at some point?  It always
completely throws me that we're implementing HttpUrlRequest methods in
UrlRequest.java, but UrlRequest does not implement HttpUrlRequest.

Seems like I have to figure that out again in every CL.

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:420: private
class ResponseHeadersMap extends HashMap<String, List<String> > {
nit:  Is the space between the two ">" needed?  It's not used elsewhere.

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
File components/cronet/android/org_chromium_net_UrlRequest.cc (right):

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
components/cronet/android/org_chromium_net_UrlRequest.cc:336: // null key; in
HTTP's case, this maps to the HTTP status line.
Should this be documented in HttpUrlRequest?

[mef, 2014-08-05 17:55:09]

thanks!

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
File components/cronet/android/java/src/org/chromium/net/UrlRequest.java
(right):

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:282: public
Map<String, List<String>> getAllHeaders() {
On 2014/08/05 17:34:05, mmenke wrote:
> Do you mind merging ChromiumUrlRequest and UrlRequest at some point?  It
always
> completely throws me that we're implementing HttpUrlRequest methods in
> UrlRequest.java, but UrlRequest does not implement HttpUrlRequest.
> 
> Seems like I have to figure that out again in every CL.
sgtm

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
components/cronet/android/java/src/org/chromium/net/UrlRequest.java:420: private
class ResponseHeadersMap extends HashMap<String, List<String> > {
On 2014/08/05 17:34:05, mmenke wrote:
> nit:  Is the space between the two ">" needed?  It's not used elsewhere.

Done.

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
File components/cronet/android/org_chromium_net_UrlRequest.cc (right):

https://codereview.chromium.org/423163007/diff/20001/components/cronet/androi...
components/cronet/android/org_chromium_net_UrlRequest.cc:336: // null key; in
HTTP's case, this maps to the HTTP status line.
On 2014/08/05 17:34:05, mmenke wrote:
> Should this be documented in HttpUrlRequest?

Done.

[mef, 2014-08-05 17:55:15]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-08-05 17:56:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/423163007/40001

[commit-bot: I haz the power, 2014-08-05 21:03:17]

Change committed as 287597