Add method getAllHeaders to HttpUrlRequest.

components/cronet/android/java/src/org/chromium/net/UrlRequest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import org.apache.http.conn.ConnectTimeoutException;
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
 
 import java.io.IOException;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.UnknownHostException;
 import java.nio.ByteBuffer;
 import java.nio.channels.ReadableByteChannel;
 import java.nio.channels.WritableByteChannel;
+import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 
 /**
  * Network request using the native http stack implementation.
  */
 @JNINamespace("cronet")
 public class UrlRequest {
     private static final class ContextLock {
     }
@@ skipping 240 matching lines @@
 
     public String getContentType() {
         return mContentType;
     }
 
     public String getHeader(String name) {
         validateHeadersAvailable();
         return nativeGetHeader(mUrlRequestPeer, name);
     }
 
+    // All response headers.
+    public Map<String, List<String>> getAllHeaders() {

[mmenke, 2014/08/05 17:34:05]

Do you mind merging ChromiumUrlRequest and UrlRequest at some point?  It always
completely throws me that we're implementing HttpUrlRequest methods in
UrlRequest.java, but UrlRequest does not implement HttpUrlRequest.

Seems like I have to figure that out again in every CL.

[mef, 2014/08/05 17:55:08]

sgtm

+        validateHeadersAvailable();
+        ResponseHeadersMap result = new ResponseHeadersMap();
+        nativeGetAllHeaders(mUrlRequestPeer, result);
+        return result;
+    }
+
     /**
      * A callback invoked when the first chunk of the response has arrived.
      */
     @CalledByNative
     protected void onResponseStarted() {
         mContentType = nativeGetContentType(mUrlRequestPeer);
         mContentLength = nativeGetContentLength(mUrlRequestPeer);
         mHeadersAvailable = true;
     }
 
@@ skipping 39 matching lines @@
             } catch (IOException e) {
                 // Ignore
             }
             onRequestComplete();
             nativeDestroyRequestPeer(mUrlRequestPeer);
             mUrlRequestPeer = 0;
             mRecycled = true;
         }
     }
 
+    /**
+     * Appends header |name| with value |value| to |headersMap|.
+     */
+    @SuppressWarnings("unused")
+    @CalledByNative
+    private void onAppendResponseHeader(ResponseHeadersMap headersMap,
+            String name, String value) {
+        if (!headersMap.containsKey(name)) {
+            headersMap.put(name, new ArrayList<String>());
+        }
+        headersMap.get(name).add(value);
+    }
+
     private void validateNotRecycled() {
         if (mRecycled) {
             throw new IllegalStateException("Accessing recycled request");
         }
     }
 
     private void validateNotStarted() {
         if (mStarted) {
             throw new IllegalStateException("Request already started");
         }
@@ skipping 34 matching lines @@
 
     private native int nativeGetHttpStatusCode(long urlRequestPeer);
 
     private native String nativeGetErrorString(long urlRequestPeer);
 
     private native String nativeGetContentType(long urlRequestPeer);
 
     private native long nativeGetContentLength(long urlRequestPeer);
 
     private native String nativeGetHeader(long urlRequestPeer, String name);
+
+    private native void nativeGetAllHeaders(long urlRequestPeer,
+            ResponseHeadersMap headers);
+
+    // Explicit class to work around JNI-generator generics confusion.
+    private class ResponseHeadersMap extends HashMap<String, List<String> > {

[mmenke, 2014/08/05 17:34:05]

nit:  Is the space between the two ">" needed?  It's not used elsewhere.

[mef, 2014/08/05 17:55:08]

Done.

+    }
 }