Source/core/svg/SVGGraphicsElement.h - Issue 423093014: [SVG2] Make transform, gradientTransform and patternTransform presentation attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGraphicsElement.h

Issue 423093014: [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: transform attr syntax should match property, with minor quirks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/svg/GradientAttributes.h ('K') | « Source/core/svg/SVGGradientElement.cpp ('k') | Source/core/svg/SVGGraphicsElement.cpp » ('j') | Source/core/svg/SVGGraphicsElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/SVGGraphicsElement.h

diff --git a/Source/core/svg/SVGGraphicsElement.h b/Source/core/svg/SVGGraphicsElement.h

index 2862402cdd73825ecd7a5493a68f867a1f18f013..c11b782e8ee6ca45cbcb94c496d53a274f694aed 100644

--- a/Source/core/svg/SVGGraphicsElement.h

+++ b/Source/core/svg/SVGGraphicsElement.h

@@ -78,8 +78,11 @@ protected:

virtual void svgAttributeChanged(const QualifiedName&) OVERRIDE;

RefPtr<SVGAnimatedTransformList> m_transform;

+ virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;

+ virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) OVERRIDE;

private:

pdr. 2014/08/01 22:43:10 Nit: no need for the extra line.

virtual bool isSVGGraphicsElement() const OVERRIDE FINAL { return true; }

// Used by <animateMotion>

« Source/core/svg/GradientAttributes.h ('K') | « Source/core/svg/SVGGradientElement.cpp ('k') | Source/core/svg/SVGGraphicsElement.cpp » ('j') | Source/core/svg/SVGGraphicsElement.cpp » ('J')