Issue 423093013: Move DeserializeJsonData() and UTF-8 conversion code to SearchSuggestionParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423093013: Move DeserializeJsonData() and UTF-8 conversion code to SearchSuggestionParser (Closed)

Created:
6 years, 4 months ago by hashimoto

Modified:
6 years, 4 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move DeserializeJsonData() and UTF-8 conversion code to SearchSuggestionParser Move BaseSearchProvider::DeserializeJsonData() and UTF-8 conversion code to SearchSuggestionParser. To reduce the number of arguments of ParseSuggestResults(), add relevances_from_server and answers_image_urls to SearchSuggestionParser::Results. BUG=388515 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286777

Patch Set 1 : #

Patch Set 2 : Clear image URLs #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -83 lines)			Patch
M	chrome/browser/autocomplete/base_search_provider.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/autocomplete/base_search_provider.cc	View		5 chunks	+13 lines, -55 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/zero_suggest_provider.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	components/autocomplete/search_suggestion_parser.h	View		4 chunks	+20 lines, -8 lines	0 comments	Download
M	components/autocomplete/search_suggestion_parser.cc	View	1	8 chunks	+57 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/423093013/40001

6 years, 4 months ago (2014-07-31 02:59:21 UTC) #4

Message was sent while issue was closed.

Change committed as 286777

Expand Messages | Collapse Messages