Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 423093009: Ensure LModByPowerOf2I only gets environment when it deopts. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger
Modified:
6 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Ensure LModByPowerOf2I only gets environment when it deopts. R=svenpanne@chromium.org TEST=mozilla (with new --always-opt) Committed: https://code.google.com/p/v8/source/detail?r=22803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/lithium-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 4 months ago (2014-07-30 08:39:46 UTC) #1
Sven Panne
lgtm
6 years, 4 months ago (2014-07-30 12:17:07 UTC) #2
Michael Starzinger
6 years, 4 months ago (2014-08-04 08:47:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698