src/x64/lithium-x64.cc - Issue 423093009: Ensure LModByPowerOf2I only gets environment when it deopts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 423093009: Ensure LModByPowerOf2I only gets environment when it deopts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index af57996bbea638e10da47be5b0d077e68d5df8c9..d73536e8629a019b8775104a6dc8430f95215188 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -1445,7 +1445,8 @@ LInstruction* LChunkBuilder::DoModByPowerOf2I(HMod* instr) {

int32_t divisor = instr->right()->GetInteger32Constant();

LInstruction* result = DefineSameAsFirst(new(zone()) LModByPowerOf2I(

dividend, divisor));

- if (instr->CheckFlag(HValue::kBailoutOnMinusZero)) {

+ if (instr->CheckFlag(HValue::kLeftCanBeNegative) &&

+ instr->CheckFlag(HValue::kBailoutOnMinusZero)) {

result = AssignEnvironment(result);

}

return result;

« no previous file with comments | « src/mips64/lithium-mips64.cc ('k') | src/x87/lithium-x87.cc » ('j') | no next file with comments »