Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issue 423083005: enable code completion integration test stub (Closed)

Created:
6 years, 4 months ago by danrubel
Modified:
6 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

enable code completion integration test stub (DROPPED) BUG=

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M pkg/analysis_server/test/completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +9 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/operation/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
6 years, 4 months ago (2014-07-29 14:56:19 UTC) #1
Paul Berry
https://codereview.chromium.org/423083005/diff/1/pkg/analysis_server/test/integration/test_all.dart File pkg/analysis_server/test/integration/test_all.dart (right): https://codereview.chromium.org/423083005/diff/1/pkg/analysis_server/test/integration/test_all.dart#newcode9 pkg/analysis_server/test/integration/test_all.dart:9: //import 'analysis_domain_int_test.dart' as analysis_domain_inttest; Why are the other integration ...
6 years, 4 months ago (2014-07-29 15:28:45 UTC) #2
danrubel
Reverted test suite change. PTAL. https://codereview.chromium.org/423083005/diff/1/pkg/analysis_server/test/test_all.dart File pkg/analysis_server/test/test_all.dart (right): https://codereview.chromium.org/423083005/diff/1/pkg/analysis_server/test/test_all.dart#newcode50 pkg/analysis_server/test/test_all.dart:50: integration_test_all.main(); On 2014/07/29 15:28:45, ...
6 years, 4 months ago (2014-07-29 16:09:28 UTC) #3
danrubel
6 years, 4 months ago (2014-07-29 16:30:58 UTC) #4
On 2014/07/29 16:09:28, danrubel wrote:
> Reverted test suite change. PTAL.
> 
>
https://codereview.chromium.org/423083005/diff/1/pkg/analysis_server/test/tes...
> File pkg/analysis_server/test/test_all.dart (right):
> 
>
https://codereview.chromium.org/423083005/diff/1/pkg/analysis_server/test/tes...
> pkg/analysis_server/test/test_all.dart:50: integration_test_all.main();
> On 2014/07/29 15:28:45, Paul Berry wrote:
> > Actually, I left integration tests out of this list on purpose.  My
reasoning
> > was: this is the collection of tests that we want to be able to run quickly
> and
> > without having to do a full build.  The integration tests are slow, and will
> > eventually require a full build (since they will operate on the analysis
> server
> > snapshot as soon as the infrastructure has been created for that).
> > 
> > So I would rather leave this file as is.
> 
> Ah! Good point. Reverted.

Dropping this CL per discussion since you are already making similar changes.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698