Issue 423083004: Fix handling of potential string additions in hydrogen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423083004: Fix handling of potential string additions in hydrogen. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger

Modified:
6 years, 4 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix handling of potential string additions in hydrogen. R=titzer@chromium.org TEST=mjsunit/regress/regress-3476 BUG=v8:3476 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=22677

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	src/hydrogen.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-3476.js	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

titzer

lgtm but maybe that predicate should be called is_not_string_add!

6 years, 4 months ago (2014-07-29 14:38:18 UTC) #2

Michael Starzinger

6 years, 4 months ago (2014-07-29 14:53:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22677 (presubmit successful).