src/hydrogen.cc - Issue 423083004: Fix handling of potential string additions in hydrogen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 423083004: Fix handling of potential string additions in hydrogen. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index fe8e134d97308dd6aac417806e9317725b48cde9..e85e16a6386b28f93ff661421cd8786ed8eb2608 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -10240,7 +10240,9 @@ HValue* HGraphBuilder::BuildBinaryOperation(

bool maybe_string_add = op == Token::ADD &&

(left_type->Maybe(Type::String()) ||

- right_type->Maybe(Type::String()));

+ left_type->Maybe(Type::Receiver()) ||

+ right_type->Maybe(Type::String()) ||

+ right_type->Maybe(Type::Receiver()));

if (left_type->Is(Type::None())) {

Add<HDeoptimize>("Insufficient type feedback for LHS of binary operation",

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-3476.js » ('j') | no next file with comments »