Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 422933003: Add enabling/disabling of NetworkInformation API via WebRuntimeFeatures. (Closed)

Created:
6 years, 4 months ago by jkarlin
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add enabling/disabling of NetworkInformation API via WebRuntimeFeatures. This lets us restrict the API to the platforms that are fully implemented while we develop the others. See https://codereview.chromium.org/424823002/ for the Chromium code that uses this. BUG=368358 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jkarlin
jochen: Please review all, and thanks!
6 years, 4 months ago (2014-07-28 17:01:38 UTC) #1
jkarlin
On 2014/07/28 17:01:38, jkarlin wrote: > jochen: Please review all, and thanks! Ping? Thanks jochen!
6 years, 4 months ago (2014-07-29 11:21:05 UTC) #2
Peter Beverloo
On 2014/07/29 11:21:05, jkarlin wrote: > On 2014/07/28 17:01:38, jkarlin wrote: > > jochen: Please ...
6 years, 4 months ago (2014-07-29 11:24:34 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-29 11:24:47 UTC) #4
jochen (gone - plz use gerrit)
(but yes, explaining why you need this would help)
6 years, 4 months ago (2014-07-29 11:25:18 UTC) #5
jkarlin
On 2014/07/29 11:24:34, Peter Beverloo wrote: > On 2014/07/29 11:21:05, jkarlin wrote: > > On ...
6 years, 4 months ago (2014-07-29 11:29:20 UTC) #6
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-29 11:30:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/422933003/1
6 years, 4 months ago (2014-07-29 11:31:37 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 12:22:50 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 13:49:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19441)
6 years, 4 months ago (2014-07-29 13:49:24 UTC) #11
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-29 14:40:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/422933003/1
6 years, 4 months ago (2014-07-29 14:41:53 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 14:43:18 UTC) #14
Message was sent while issue was closed.
Change committed as 179147

Powered by Google App Engine
This is Rietveld 408576698