Use tighter typing in editing: htmlediting create methods

Use tighter typing in editing: htmlediting create methods

Use tighter typing in editing/ to increase code readability.
This CL focuses on the create*Element() functions in htmlediting.

R=leviw@chromium.org, yosin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179173

[yosin_UTC9, 2014-07-28 00:59:00]

LGTM

It is more readabile. Thanks!
Please wait for OWNERS lgtm for committing.

[Inactive, 2014-07-29 12:02:11]

On 2014/07/28 00:59:00, Yosi_UTC9 wrote:
> LGTM
> 
> It is more readabile. Thanks!
> Please wait for OWNERS lgtm for committing.

Thanks, Levi, can you please take a look?

[leviw_travelin_and_unemployed, 2014-07-29 18:23:07]

lgtm

[leviw_travelin_and_unemployed, 2014-07-29 18:23:10]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-07-29 18:24:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/422693002/1

[commit-bot: I haz the power, 2014-07-29 18:24:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 18:24:14]

Failed to apply patch for Source/core/editing/CompositeEditCommand.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/CompositeEditCommand.cpp
  Hunk #1 FAILED at 65.
  Hunk #2 succeeded at 1304 (offset 3 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/editing/CompositeEditCommand.cpp.rej

Patch:       Source/core/editing/CompositeEditCommand.cpp
Index: Source/core/editing/CompositeEditCommand.cpp
diff --git a/Source/core/editing/CompositeEditCommand.cpp
b/Source/core/editing/CompositeEditCommand.cpp
index
5a50f50284f2f632e07c45cf989486b76371c3a0..00f6687454ecc505b5d9e7ea671bf1416c37385f
100644
--- a/Source/core/editing/CompositeEditCommand.cpp
+++ b/Source/core/editing/CompositeEditCommand.cpp
@@ -65,6 +65,7 @@
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLBRElement.h"
 #include "core/html/HTMLElement.h"
+#include "core/html/HTMLLIElement.h"
 #include "core/html/HTMLSpanElement.h"
 #include "core/rendering/InlineTextBox.h"
 #include "core/rendering/RenderBlock.h"
@@ -1301,7 +1302,7 @@ bool CompositeEditCommand::breakOutOfEmptyListItem()
         || listNode == emptyListItem->rootEditableElement())
         return false;
 
-    RefPtrWillBeRawPtr<Element> newBlock = nullptr;
+    RefPtrWillBeRawPtr<HTMLElement> newBlock = nullptr;
     if (ContainerNode* blockEnclosingList = listNode->parentNode()) {
         if (isHTMLLIElement(*blockEnclosingList)) { // listNode is inside
another list item
             if (visiblePositionAfterNode(*blockEnclosingList) ==
visiblePositionAfterNode(*listNode)) {

[Inactive, 2014-07-29 18:56:01]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-07-29 18:56:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/422693002/20001

[commit-bot: I haz the power, 2014-07-29 20:14:33]

Change committed as 179173