Source/core/editing/ReplaceSelectionCommand.cpp - Issue 422693002: Use tighter typing in editing: htmlediting create methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 422693002: Use tighter typing in editing: htmlediting create methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index a73f851f668c755a4558be2f787dfc4006cff978..29929ba2bb991d53aa5953510148538a0eca343d 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -52,6 +52,7 @@

#include "core/html/HTMLBRElement.h"

#include "core/html/HTMLElement.h"

#include "core/html/HTMLInputElement.h"

+#include "core/html/HTMLLIElement.h"

#include "core/rendering/RenderObject.h"

#include "core/rendering/RenderText.h"

#include "wtf/StdLibExtras.h"

@@ -1215,7 +1216,7 @@ void ReplaceSelectionCommand::doApply()

setEndingSelection(endOfInsertedContent);

Node* enclosingNode = enclosingBlock(endOfInsertedContent.deepEquivalent().deprecatedNode());

if (isListItem(enclosingNode)) {

- RefPtrWillBeRawPtr<Node> newListItem = createListItemElement(document());

+ RefPtrWillBeRawPtr<HTMLLIElement> newListItem = createListItemElement(document());

insertNodeAfter(newListItem, enclosingNode);

setEndingSelection(VisiblePosition(firstPositionInNode(newListItem.get())));

} else {

« no previous file with comments | « Source/core/editing/InsertListCommand.cpp ('k') | Source/core/editing/htmlediting.h » ('j') | no next file with comments »