GN: Put shared libraries in outdir, not outdir/lib

GN: Put shared libraries in outdir, not outdir/lib

There's no reason to have shared libraries hidden in a separate out dir.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286740

[jamesr, 2014-07-25 23:20:57]

We can't think of any reason this wouldn't work...

[Nico, 2014-07-26 19:49:59]

lgtm

https://codereview.chromium.org/422633002/diff/1/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/422633002/diff/1/build/config/gcc/BUILD.gn#ne...
build/config/gcc/BUILD.gn:25: "-Wl,-rpath=\$ORIGIN/",
Brett: FYI, the CrOS folks were pretty interested in not passing this if there
are no shared library deps, for security reasons (
https://code.google.com/p/gyp/issues/detail?id=315 /
https://codereview.chromium.org/11821060/ ). So this might need work in gn (or
maybe only executables that need it use executable_lconfig, in that case nvm)

[jamesr, 2014-07-29 01:23:01]

This is currently blocked on the ffmpegsumo_copy rule in
third_party/ffmpeg/BUILD.gn

Not sure if we have enough power to do the thing CrOS wants right now.

[jamesr, 2014-07-29 03:56:02]

https://codereview.chromium.org/422633002/diff/1/build/config/gcc/BUILD.gn
File build/config/gcc/BUILD.gn (right):

https://codereview.chromium.org/422633002/diff/1/build/config/gcc/BUILD.gn#ne...
build/config/gcc/BUILD.gn:25: "-Wl,-rpath=\$ORIGIN/",
On 2014/07/26 19:49:59, Nico (away) wrote:
> Brett: FYI, the CrOS folks were pretty interested in not passing this if there
> are no shared library deps, for security reasons (
> https://code.google.com/p/gyp/issues/detail?id=315 /
> https://codereview.chromium.org/11821060/ ). So this might need work in gn (or
> maybe only executables that need it use executable_lconfig, in that case nvm)

Thinking about it more it should be sufficient to do 'configs -= [
"//build/config/gcc:executable_ldconfig" ] 'in whatever targets don't want this
line

[brettw, 2014-07-29 20:38:42]

lgtm

[jamesr, 2014-07-29 23:19:53]

ffmpeg patch has landed in ffmpeg, not quite sure how to roll it but I'll take a
crack at it.

[jamesr, 2014-07-30 18:28:47]

The CQ bit was checked by jamesr@chromium.org

[jamesr, 2014-07-30 18:29:16]

On 2014/07/30 18:28:47, jamesr wrote:
> The CQ bit was checked by mailto:jamesr@chromium.org

ffmpeg rolled at r286463.  With a local GN build the component build seems to be
working well with this patch.

[commit-bot: I haz the power, 2014-07-30 18:30:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/422633002/20001

[commit-bot: I haz the power, 2014-07-30 21:02:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-30 22:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 22:59:10]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jamesr, 2014-07-30 23:05:31]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-30 23:07:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/422633002/20001

[commit-bot: I haz the power, 2014-07-31 11:45:34]

Change committed as 286740