Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/gn/ninja_helper.cc

Issue 422633002: GN: Put shared libraries in outdir, not outdir/lib (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_helper.cc
diff --git a/tools/gn/ninja_helper.cc b/tools/gn/ninja_helper.cc
index cc03dd566703f0f010be2c0056c7305b23c1b43b..956e74c276b3d5db021e242de2b795d3c558b577 100644
--- a/tools/gn/ninja_helper.cc
+++ b/tools/gn/ninja_helper.cc
@@ -12,7 +12,6 @@
namespace {
-const char kLibDirWithSlash[] = "lib/";
const char kObjectDirNoSlash[] = "obj";
} // namespace
@@ -178,10 +177,9 @@ OutputFile NinjaHelper::GetTargetOutputFile(const Target* target) const {
// default toolchain, and will end in a slash otherwise).
ret.value().append(target->settings()->toolchain_output_subdir().value());
- // Binaries and loadable libraries go into the toolchain root.
+ // Binaries and shared libraries go into the toolchain root.
if (target->output_type() == Target::EXECUTABLE ||
- ((target->settings()->IsMac() || target->settings()->IsWin()) &&
- target->output_type() == Target::SHARED_LIBRARY)) {
+ target->output_type() == Target::SHARED_LIBRARY) {
// Generate a name like "<toolchain>/<prefix><name>.<extension>".
ret.value().append(prefix);
ret.value().append(name);
@@ -192,19 +190,6 @@ OutputFile NinjaHelper::GetTargetOutputFile(const Target* target) const {
return ret;
}
- // Libraries go into the library subdirectory like
- // "<toolchain>/lib/<prefix><name>.<extension>".
- if (target->output_type() == Target::SHARED_LIBRARY) {
- ret.value().append(kLibDirWithSlash);
- ret.value().append(prefix);
- ret.value().append(name);
- if (extension[0]) {
- ret.value().push_back('.');
- ret.value().append(extension);
- }
- return ret;
- }
-
// Everything else goes next to the target's .ninja file like
// "<toolchain>/obj/<path>/<name>.<extension>".
ret.value().append(kObjectDirNoSlash);
« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698