Initial GetSample implementation.

src/profile-generator.cc

Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index 945bdd6cc12f5ea883ea6a30a12c24f938b81de2..abcccbdc176d3b1b19fb27b179a84ba364de94c7 100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -628,7 +628,7 @@ void ProfileGenerator::RecordTickSample(const TickSample& sample) {
       }
     }
 
-    for (const Address* stack_pos = sample.stack,
+    for (const Address* stack_pos = reinterpret_cast<const Address*>(sample.stack),

[Sven Panne, 2014/09/02 08:15:02]

static_cast again, the const seems to be unnecessary here.

[gholap, 2014/09/02 08:56:08]

Hmm... that should work for individual pointers, right? and not arrays of
pointers?
(won't compile unless reinterpret_cast and const both are present...)

[Sven Panne, 2014/09/02 11:15:36]

Done correctly, it *would* work, but actually there is a far easier way than
this unreadable pointer fiddling:

  for (unsigned i = 0; i < sample.frames_count; ++i) {
    *entry++ = code_map_.FindEntry(static_cast<Address>(sample.stack[i]));
  }

Looking at the use sites, you might even consider replacing the old-skool
array+size interface of Sample by an iterator interface with begin() and end(),
so one could write (in C++11, available soon):

  for (auto slot: sample) {
    *entry++ = code_map_.FindEntry(static_cast<Address>(slot));
  }

[gholap, 2014/09/02 14:43:11]

Done. I know where I went wrong! I took my working thumb-rule to be edit/touch
as few lines of code as possible :P That way, I didn't even consider what is
going on inside the for loop! I'll make efforts to avoid such thing
henceforth...

            *stack_end = stack_pos + sample.frames_count;
          stack_pos != stack_end;
          ++stack_pos) {