Chromium Code Reviews| Index: src/log.cc |
| diff --git a/src/log.cc b/src/log.cc |
| index 6d88a535dc78f4ce10ce7a578d56d1b7b32b4e7c..e553feb14f4844b1ed299d5705d0c0df90c8e9be 100644 |
| --- a/src/log.cc |
| +++ b/src/log.cc |
| @@ -1720,7 +1720,7 @@ void Logger::TickEvent(TickSample* sample, bool overflow) { |
| } |
| for (unsigned i = 0; i < sample->frames_count; ++i) { |
| msg.Append(','); |
| - msg.AppendAddress(sample->stack[i]); |
| + msg.AppendAddress(reinterpret_cast<Address>(sample->stack[i])); |
|
Sven Panne
2014/09/02 08:15:01
Always use the least powerful cast possible: A sta
gholap
2014/09/02 08:56:08
Done.
|
| } |
| msg.Append('\n'); |
| msg.WriteToLogFile(); |
| @@ -2060,6 +2060,13 @@ bool Logger::SetUp(Isolate* isolate) { |
| profiler_->Engage(); |
| } |
| + // TODO(gholap): This one's for the new sampler API. (include/v8-sampler.h) |
| + // Call to IncreaseProfilingDepth causes the |
| + // SIGPROF signal handler to be installed on the VM thread. |
| + // Figure out whether there's a way to only optionally |
| + // do this based on a runtime flag. |
| + ticker_->IncreaseProfilingDepth(); |
| + |
| if (FLAG_log_internal_timer_events || FLAG_prof) timer_.Start(); |
| return true; |