|
Revert 285661 "Remove some dead app host code."
Causes compile failures on official builders:
e.g.,
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/
FAILED: ninja -t msvc -e environment.x64 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj.rsp /c ..\..\chrome\installer\util\chrome_app_host_distribution.cc /Foobj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj /Fdobj\chrome\installer_util_nacl_win64.cc.pdb
c:\b\build\slave\google-chrome-rel-win\build\src\chrome\installer\util\chrome_app_host_distribution.cc(126) :error C2065: 'kChromeAppHostGuid' : undeclared identifier
ninja: build stopped: subcommand failed.
> Remove some dead app host code.
>
> app_host.exe was removed in r220555. This change removes some dead code
> that was left behind. Specifically:
> - chrome_launcher_support no longer exposes any methods related to the
> AppHost.
> - Chrome's uninstall prompt no longer has a special case to handle
> suppressing the "delete your profile" checkbox.
> - Chrome and its installer no longer have a dependency on
> launcher_support.
> - The installer no longer supports installing items from the webstore.
> - GetUntrustedDataValue no longer has consumers and is gone.
>
> BUG= 297647
> R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org
>
> Review URL: https://codereview.chromium.org/422453004
TBR=grt@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285706
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+394 lines, -48 lines) |
Patch |
 |
M |
trunk/src/chrome/browser/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chrome_browser_main_win.cc
|
View
|
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/extensions/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/uninstall_browser_prompt.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/views/app_list/win/app_list_service_win.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/views/uninstall_view.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/views/uninstall_view.cc
|
View
|
|
5 chunks |
+18 lines, -13 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser_extensions.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser_ui.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_installer.gypi
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/launcher_support/chrome_launcher_support.h
|
View
|
|
1 chunk |
+54 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/launcher_support/chrome_launcher_support.cc
|
View
|
|
7 chunks |
+130 lines, -16 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/setup/install.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/setup/install.cc
|
View
|
|
3 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/setup/setup_constants.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/setup/setup_constants.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/setup/setup_main.cc
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/setup/uninstall.cc
|
View
|
|
2 chunks |
+18 lines, -11 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/util/chrome_app_host_distribution.cc
|
View
|
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/util/google_update_util.h
|
View
|
|
2 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/util/google_update_util.cc
|
View
|
|
4 chunks |
+100 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/util/util_constants.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/installer/util/util_constants.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|