Remove some dead app host code.

Remove some dead app host code.

app_host.exe was removed in r220555. This change removes some dead code
that was left behind. Specifically:
- chrome_launcher_support no longer exposes any methods related to the
  AppHost.
- Chrome's uninstall prompt no longer has a special case to handle
  suppressing the "delete your profile" checkbox.
- Chrome and its installer no longer have a dependency on
  launcher_support.
- The installer no longer supports installing items from the webstore.
- GetUntrustedDataValue no longer has consumers and is gone.

BUG=297647
R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285661

[benwells, 2014-07-25 04:46:56]

Nice. chrome/browser lgtm.

Do we need to keep the installer/launcher_support stuff that is left?

[gab, 2014-07-25 12:25:13]

Cool, couple questions below, but otherwise lgtm (with hopes of future CLs to
remove the remaining APP_HOST code?!).

Cheers!
Gab

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/s...
File chrome/installer/setup/setup_main.cc (left):

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/s...
chrome/installer/setup/setup_main.cc:1643: if
(prefs.install_chrome_app_launcher() &&
Can probably also remove install_chrome_app_launcher() from
master_preferences.h?

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/u...
File chrome/installer/setup/uninstall.cc (left):

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/u...
chrome/installer/setup/uninstall.cc:1285: // If we're not uninstalling the
legacy App Launcher, and if it was
The "legacy App Launcher" never shipped beyond Dev, is that correct?

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/util/ch...
File chrome/installer/util/chrome_app_host_distribution.cc (right):

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/util/ch...
chrome/installer/util/chrome_app_host_distribution.cc:10: #include
"chrome/installer/util/chrome_app_host_distribution.h"
What's left for us to be able to remove this distribution altogether?! :-)

[grt (UTC plus 2), 2014-07-25 14:20:27]

+sky for chrome/* OWNERS stamp

benwells: the rest of installer/launcher_support is used by gcapi and by
cloud_print, so it stays. thanks for asking.

gab: very much appreciate the comments and questions.

huangs: please take a look, especially at gab's question and my response in
uninstall.cc. thanks.

cheers

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/s...
File chrome/installer/setup/setup_main.cc (left):

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/s...
chrome/installer/setup/setup_main.cc:1643: if
(prefs.install_chrome_app_launcher() &&
On 2014/07/25 12:25:13, gab wrote:
> Can probably also remove install_chrome_app_launcher() from
> master_preferences.h?

eventually, yes. my goal in this CL was to get rid of install.cc's
InstallFromWebstore and everything that this removal enabled. there is a whole
lot more that needs to be removed. i'm getting the ball rolling, so to speak.

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/u...
File chrome/installer/setup/uninstall.cc (left):

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/u...
chrome/installer/setup/uninstall.cc:1285: // If we're not uninstalling the
legacy App Launcher, and if it was
On 2014/07/25 12:25:13, gab wrote:
> The "legacy App Launcher" never shipped beyond Dev, is that correct?

i don't really know. my understand is this (sam: please correct me if i'm
wrong): if someone somehow still has it on their system, then something has gone
horribly wrong. i can't imagine how leaving the shadow registry key behind on
chrome uninstall would be the right thing.

now that i look at it, i think it's wrong for any operations on the shadow
registry key (which is used for counting uses of the app list) to be conditional
on chrome being multi-install. i've added a TODO to fix this.

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/util/ch...
File chrome/installer/util/chrome_app_host_distribution.cc (right):

https://codereview.chromium.org/422453004/diff/20001/chrome/installer/util/ch...
chrome/installer/util/chrome_app_host_distribution.cc:10: #include
"chrome/installer/util/chrome_app_host_distribution.h"
On 2014/07/25 12:25:13, gab wrote:
> What's left for us to be able to remove this distribution altogether?! :-)

a lot more code needs to be removed.

[gab, 2014-07-25 14:25:22]

Thanks, still lgtm.

On 2014/07/25 14:20:27, grt wrote:
> +sky for chrome/* OWNERS stamp
> 
> benwells: the rest of installer/launcher_support is used by gcapi and by
> cloud_print, so it stays. thanks for asking.

ugh... this dependency sounds wrong, if such generic code is required it should
probably be moved elsewhere, "launcher" is essentially meaningless now (not a
blocker for this CL).



> 
> gab: very much appreciate the comments and questions.
> 
> huangs: please take a look, especially at gab's question and my response in
> uninstall.cc. thanks.
> 
> cheers
> 
>
https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/s...
> File chrome/installer/setup/setup_main.cc (left):
> 
>
https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/s...
> chrome/installer/setup/setup_main.cc:1643: if
> (prefs.install_chrome_app_launcher() &&
> On 2014/07/25 12:25:13, gab wrote:
> > Can probably also remove install_chrome_app_launcher() from
> > master_preferences.h?
> 
> eventually, yes. my goal in this CL was to get rid of install.cc's
> InstallFromWebstore and everything that this removal enabled. there is a whole
> lot more that needs to be removed. i'm getting the ball rolling, so to speak.
> 
>
https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/u...
> File chrome/installer/setup/uninstall.cc (left):
> 
>
https://codereview.chromium.org/422453004/diff/20001/chrome/installer/setup/u...
> chrome/installer/setup/uninstall.cc:1285: // If we're not uninstalling the
> legacy App Launcher, and if it was
> On 2014/07/25 12:25:13, gab wrote:
> > The "legacy App Launcher" never shipped beyond Dev, is that correct?
> 
> i don't really know. my understand is this (sam: please correct me if i'm
> wrong): if someone somehow still has it on their system, then something has
gone
> horribly wrong. i can't imagine how leaving the shadow registry key behind on
> chrome uninstall would be the right thing.
> 
> now that i look at it, i think it's wrong for any operations on the shadow
> registry key (which is used for counting uses of the app list) to be
conditional
> on chrome being multi-install. i've added a TODO to fix this.
> 
>
https://codereview.chromium.org/422453004/diff/20001/chrome/installer/util/ch...
> File chrome/installer/util/chrome_app_host_distribution.cc (right):
> 
>
https://codereview.chromium.org/422453004/diff/20001/chrome/installer/util/ch...
> chrome/installer/util/chrome_app_host_distribution.cc:10: #include
> "chrome/installer/util/chrome_app_host_distribution.h"
> On 2014/07/25 12:25:13, gab wrote:
> > What's left for us to be able to remove this distribution altogether?! :-)
> 
> a lot more code needs to be removed.

[grt (UTC plus 2), 2014-07-25 14:38:27]

On 2014/07/25 14:25:22, gab wrote:
> On 2014/07/25 14:20:27, grt wrote:
> > benwells: the rest of installer/launcher_support is used by gcapi and by
> > cloud_print, so it stays. thanks for asking.
> 
> ugh... this dependency sounds wrong, if such generic code is required it
should
> probably be moved elsewhere, "launcher" is essentially meaningless now (not a
> blocker for this CL).

good point, the name is a misnomer now. the lib is used by gcapi and cloud_print
to find chrome, which is tightly related to the way chrome is installed, so i
think chrome/installer/somethingorother is a reasonable place for it to live.

[grt (UTC plus 2), 2014-07-25 14:49:24]

On 2014/07/25 14:38:27, grt wrote:
> On 2014/07/25 14:25:22, gab wrote:
> > On 2014/07/25 14:20:27, grt wrote:
> > > benwells: the rest of installer/launcher_support is used by gcapi and by
> > > cloud_print, so it stays. thanks for asking.
> > 
> > ugh... this dependency sounds wrong, if such generic code is required it
> should
> > probably be moved elsewhere, "launcher" is essentially meaningless now (not
a
> > blocker for this CL).
> 
> good point, the name is a misnomer now. the lib is used by gcapi and
cloud_print
> to find chrome, which is tightly related to the way chrome is installed, so i
> think chrome/installer/somethingorother is a reasonable place for it to live.

oh, i forgot to mention: i found that other functions in chrome_launcher_support
were no longer called, so i've pruned it further.

[gab, 2014-07-25 15:21:15]

On 2014/07/25 14:49:24, grt wrote:
> On 2014/07/25 14:38:27, grt wrote:
> > On 2014/07/25 14:25:22, gab wrote:
> > > On 2014/07/25 14:20:27, grt wrote:
> > > > benwells: the rest of installer/launcher_support is used by gcapi and by
> > > > cloud_print, so it stays. thanks for asking.
> > > 
> > > ugh... this dependency sounds wrong, if such generic code is required it
> > should
> > > probably be moved elsewhere, "launcher" is essentially meaningless now
(not
> a
> > > blocker for this CL).
> > 
> > good point, the name is a misnomer now. the lib is used by gcapi and
> cloud_print
> > to find chrome, which is tightly related to the way chrome is installed, so
i
> > think chrome/installer/somethingorother is a reasonable place for it to
live.
> 
> oh, i forgot to mention: i found that other functions in
chrome_launcher_support
> were no longer called, so i've pruned it further.

woot, lgtm++!

[grt (UTC plus 2), 2014-07-25 15:30:27]

+cc jackhou: i'm removing code you added in r256091 since it is dead code with
no unit tests. feel free to add it back in if/when you're ready to use it.

[huangs, 2014-07-25 15:56:42]

LGTM with nits, and please talk to jackhou@.

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
File chrome/installer/setup/install.cc (left):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
chrome/installer/setup/install.cc:694: bool InstallFromWebstore(const
std::string& app_code) {
Also remove from install.h.

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
File chrome/installer/setup/install.cc (right):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
chrome/installer/setup/install.cc:13: #include "base/command_line.h"
Can remove
#include "base/command_line.h"
?

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
File chrome/installer/util/google_update_util.cc (left):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
chrome/installer/util/google_update_util.cc:281: std::string
GetUntrustedDataValueFromTag(const std::string& tag,
Note that GetUntrustedDataValueFromTag()  is added 4 month ago by jackhou@ in
https://codereview.chromium.org/180243021 .

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
File chrome/installer/util/google_update_util.h (right):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
chrome/installer/util/google_update_util.h:8: #include <string>
Remove
#include <string>
?

[sky, 2014-07-25 16:28:12]

LGTM

[grt (UTC plus 2), 2014-07-25 17:17:03]

awesome. thanks, sam.

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
File chrome/installer/setup/install.cc (left):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
chrome/installer/setup/install.cc:694: bool InstallFromWebstore(const
std::string& app_code) {
On 2014/07/25 15:56:41, huangs1 wrote:
> Also remove from install.h.

Done.

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
File chrome/installer/setup/install.cc (right):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/setup/i...
chrome/installer/setup/install.cc:13: #include "base/command_line.h"
On 2014/07/25 15:56:41, huangs1 wrote:
> Can remove
> #include "base/command_line.h"
> ?

Done.

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
File chrome/installer/util/google_update_util.cc (left):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
chrome/installer/util/google_update_util.cc:281: std::string
GetUntrustedDataValueFromTag(const std::string& tag,
On 2014/07/25 15:56:41, huangs1 wrote:
> Note that GetUntrustedDataValueFromTag()  is added 4 month ago by jackhou@ in
> https://codereview.chromium.org/180243021 . 

thanks. i've CC'd him so he sees that i'm removing it.

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
File chrome/installer/util/google_update_util.h (right):

https://codereview.chromium.org/422453004/diff/40001/chrome/installer/util/go...
chrome/installer/util/google_update_util.h:8: #include <string>
On 2014/07/25 15:56:41, huangs1 wrote:
> Remove
> #include <string>
> ?

Done.

[grt (UTC plus 2), 2014-07-25 17:17:15]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2014-07-25 17:18:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/grt@chromium.org/422453004/100001

[commit-bot: I haz the power, 2014-07-25 20:09:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[commit-bot: I haz the power, 2014-07-25 20:27:03]

Change committed as 285661