Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 422463002: Hide isXXX() type checking methods in subclasses (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Hide isXXX() type checking methods in subclasses Hide isXXX() type checking methods in subclasses in order to catch unnecessary calls at compile time. For e.g., it makes no sense to call Element::isElementNode() as it is obviously true. This CL also takes care of removing several such unnecessary calls that were caught at compile time. R=eseidel@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M Source/core/dom/Attr.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/CharacterData.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentFragment.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Text.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 5 months ago (2014-07-25 04:10:50 UTC) #1
pdr.
On 2014/07/25 04:10:50, Chris Dumez wrote: LGTM.
6 years, 5 months ago (2014-07-25 08:47:22 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-25 08:54:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/422463002/1
6 years, 5 months ago (2014-07-25 08:55:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-25 09:35:52 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 10:04:53 UTC) #6
Message was sent while issue was closed.
Change committed as 178921

Powered by Google App Engine
This is Rietveld 408576698