Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/core/dom/Attr.h

Issue 422463002: Hide isXXX() type checking methods in subclasses (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/CharacterData.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 virtual const AtomicString& localName() const OVERRIDE { return m_name.local Name(); } 60 virtual const AtomicString& localName() const OVERRIDE { return m_name.local Name(); }
61 virtual const AtomicString& namespaceURI() const OVERRIDE { return m_name.na mespaceURI(); } 61 virtual const AtomicString& namespaceURI() const OVERRIDE { return m_name.na mespaceURI(); }
62 const AtomicString& prefix() const { return m_name.prefix(); } 62 const AtomicString& prefix() const { return m_name.prefix(); }
63 63
64 virtual void trace(Visitor*) OVERRIDE; 64 virtual void trace(Visitor*) OVERRIDE;
65 65
66 private: 66 private:
67 Attr(Element&, const QualifiedName&); 67 Attr(Element&, const QualifiedName&);
68 Attr(Document&, const QualifiedName&, const AtomicString& value); 68 Attr(Document&, const QualifiedName&, const AtomicString& value);
69 69
70 bool isElementNode() const WTF_DELETED_FUNCTION; // Hide to catch useless ca lls.
71
70 void createTextChild(); 72 void createTextChild();
71 73
72 void setValueInternal(const AtomicString&); 74 void setValueInternal(const AtomicString&);
73 75
74 virtual String nodeName() const OVERRIDE { return name(); } 76 virtual String nodeName() const OVERRIDE { return name(); }
75 virtual NodeType nodeType() const OVERRIDE { return ATTRIBUTE_NODE; } 77 virtual NodeType nodeType() const OVERRIDE { return ATTRIBUTE_NODE; }
76 78
77 virtual String nodeValue() const OVERRIDE { return value(); } 79 virtual String nodeValue() const OVERRIDE { return value(); }
78 virtual void setNodeValue(const String&) OVERRIDE; 80 virtual void setNodeValue(const String&) OVERRIDE;
79 virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE; 81 virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE;
(...skipping 15 matching lines...) Expand all
95 // use a single field. 97 // use a single field.
96 AtomicString m_standaloneValueOrAttachedLocalName; 98 AtomicString m_standaloneValueOrAttachedLocalName;
97 unsigned m_ignoreChildrenChanged; 99 unsigned m_ignoreChildrenChanged;
98 }; 100 };
99 101
100 DEFINE_NODE_TYPE_CASTS(Attr, isAttributeNode()); 102 DEFINE_NODE_TYPE_CASTS(Attr, isAttributeNode());
101 103
102 } // namespace blink 104 } // namespace blink
103 105
104 #endif // Attr_h 106 #endif // Attr_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/CharacterData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698