Issue 422343003: Revert 179125 "Drop the 'WebURLRequest::TargetType' enum."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422343003: Revert 179125 "Drop the 'WebURLRequest::TargetType' enum." (Closed)

Created:
6 years, 4 months ago by Ken Russell (switch to Gerrit)

Modified:
6 years, 4 months ago

Reviewers:
Mike West

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 179125 "Drop the 'WebURLRequest::TargetType' enum." Believe changes related to this introduced flakiness again in the browser. See Issue 390497. > Drop the 'WebURLRequest::TargetType' enum. > > We no longer use this enum in Chromium; everything has been ported over > to using '::RequestContext' and '::FrameType', so we can safely remove > both the enum and the translation machinery in '::setTargetType'. > > BUG=390497 > > Review URL: https://codereview.chromium.org/417483002 TBR=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179162

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -0 lines)			Patch
	M	trunk/Source/platform/exported/WebURLRequest.cpp	View		1 chunk	+164 lines, -0 lines	0 comments	Download
	M	trunk/public/platform/WebURLRequest.h	View		3 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

6 years, 4 months ago (2014-07-29 17:22:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r179162.

Expand Messages | Collapse Messages